Skip to content

[AKS PREVIEW]aks create: Change the default value of --enable-msi-auth-for-monitoring to true and add check for airgap clouds#6311

Merged
zhoxing-ms merged 9 commits intoAzure:mainfrom
wanlonghenry:main
May 26, 2023
Merged

[AKS PREVIEW]aks create: Change the default value of --enable-msi-auth-for-monitoring to true and add check for airgap clouds#6311
zhoxing-ms merged 9 commits intoAzure:mainfrom
wanlonghenry:main

Conversation

@wanlonghenry
Copy link
Contributor

@wanlonghenry wanlonghenry commented May 22, 2023 •
edited
Loading

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented May 22, 2023

Hi @wanlonghenry,
If you want to release the new extension version.
Please write the description of changes into HISTORY.rst and update setup.py.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented May 22, 2023

Hi @wanlonghenry,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@ghost ghost requested review from yanzhudd and zhoxing-ms May 22, 2023 21:17
@ghost ghost assigned zhoxing-ms May 22, 2023
@ghost ghost added the Auto-Assign Auto assign by bot label May 22, 2023
@yonzhan
Copy link
Collaborator

yonzhan commented May 22, 2023

AKS PREVIEW

@ghost ghost requested a review from yonzhan May 22, 2023 21:17
@ghost ghost added the AKS label May 22, 2023
@wanlonghenry
Copy link
Contributor Author

wanlonghenry commented May 22, 2023

cli change: Azure/azure-cli#26356

@wanlonghenry
Copy link
Contributor Author

wanlonghenry commented May 22, 2023

aks enable addons:
image

@wanlonghenry
Copy link
Contributor Author

wanlonghenry commented May 22, 2023

image

@wanlonghenry
Copy link
Contributor Author

wanlonghenry commented May 22, 2023

image

ganga1980
ganga1980 reviewed May 22, 2023
View reviewed changes
@wanlonghenry
Copy link
Contributor Author

wanlonghenry commented May 22, 2023

image

@wanlonghenry
Copy link
Contributor Author

wanlonghenry commented May 22, 2023

image

@zhoxing-ms
Copy link
Contributor

zhoxing-ms commented May 23, 2023

Do you want to release a new extension for this PR change? If so, please upgrade the version defined in the setup.py

FumingZhang
FumingZhang reviewed May 23, 2023
View reviewed changes
FumingZhang
FumingZhang approved these changes May 23, 2023
View reviewed changes
Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FumingZhang
Copy link
Member

FumingZhang commented May 24, 2023 •
edited
Loading

The corresponding change in azure-cli broke some test cases.

  • test_aks_create_default_service_with_monitoring_addon
  • test_aks_create_with_monitoring_aad_auth_msi_with_datacollectionsettings
  • test_aks_create_with_monitoring_aad_auth_msi_with_syslog
  • test_aks_create_with_monitoring_aad_auth_uai_with_syslog
  • test_aks_create_with_monitoring_legacy_auth
  • test_aks_update_to_msi_cluster_with_addons

Queued live test pipeline to verify the change.

@wanlonghenry
Copy link
Contributor Author

wanlonghenry commented May 24, 2023 •
edited
Loading

thank you @FumingZhang for this finding! The
test_aks_create_with_monitoring_aad_auth_msi_with_datacollectionsettings
test_aks_create_with_monitoring_aad_auth_msi_with_syslog
test_aks_create_with_monitoring_aad_auth_uai_with_syslog
test_aks_create_with_monitoring_legacy_auth
are related to the case sensitivity of the attribute: useAADAuth. That is only assertion error in test. Will fix the tests.

the test_aks_update_to_msi_cluster_with_addons, test_aks_create_default_service_with_monitoring_addon are related to a corner case where user is using service principle, will address that.

Question to the live test,

  1. do you know why it is not added in the checks?
  2. are we suggested to run live tests everytime?
  3. Do you suggest we removing the liveonly tag for those tests?
    Thank you!

@wanlonghenry
Copy link
Contributor Author

wanlonghenry commented May 25, 2023

the above issue fixed in: Azure/azure-cli#26528
image

@zhoxing-ms zhoxing-ms merged commit 2307db0 into Azure:main May 26, 2023
@azclibot
Copy link
Collaborator

azclibot commented May 26, 2023

[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=58433&view=results

@FumingZhang FumingZhang mentioned this pull request Jun 1, 2023
Closed
3 tasks
@tg123 tg123 mentioned this pull request Jun 21, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhoxing-ms zhoxing-ms zhoxing-ms approved these changes

@FumingZhang FumingZhang FumingZhang approved these changes

@andyliuliming andyliuliming Awaiting requested review from andyliuliming andyliuliming is a code owner

@yanzhudd yanzhudd Awaiting requested review from yanzhudd

@yonzhan yonzhan Awaiting requested review from yonzhan

+1 more reviewer

@ganga1980 ganga1980 ganga1980 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@zhoxing-ms zhoxing-ms

Labels

AKS Auto-Assign Auto assign by bot

Projects

None yet

Milestone

June 2023 (2023-07-04)

Development

Successfully merging this pull request may close these issues.

6 participants

@wanlonghenry @yonzhan @zhoxing-ms @FumingZhang @azclibot @ganga1980